Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review revised Actions Menu Button Example Using aria-activedescendant #383

Closed
3 of 4 tasks
mcking65 opened this issue Apr 26, 2017 · 3 comments
Closed
3 of 4 tasks

Review revised Actions Menu Button Example Using aria-activedescendant #383

mcking65 opened this issue Apr 26, 2017 · 3 comments
Assignees
@jnurthen @annabbott
Labels
Example Page Related to a page containing an example implementation of a pattern
Milestone
Jan 2017 Clean Up

Comments

@mcking65
Copy link
Contributor

mcking65 commented Apr 26, 2017 •
edited
Loading

@jongund added a third menu button example:
actions menu button example using aria-activedescendant
that is now ready for task force review.

Reviews requested as of April 26, 2017
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Needs Review labels Apr 26, 2017
@mcking65 mcking65 added this to the Jan 2017 Clean Up milestone Apr 26, 2017
@a11ydoer
Copy link
Contributor

a11ydoer commented May 1, 2017 •
edited
Loading

@mcking65
Review is done. It looks good.

@annabbott
Copy link

annabbott commented May 1, 2017 •
edited by jnurthen
Loading

Keyboard support > Menu: Space does not perform as documented. It does activate the menu item, causing the "Last Action" textbox to be updated, then momentarily closes and reopens the menu with focus set to Action 1. Same issue as in #382

Tested using Win10/FF 53.0
Does not reproduce with Chrome or IE 11 on Windows

@mcking65 mcking65 mentioned this issue Jun 19, 2017
Closed
mcking65 added a commit that referenced this issue Jun 19, 2017
@mcking65
Actions Menu Button Example Using aria-activedescendant: fix grammar,…
6e2f217 
… remove space key documentation

To resolve feedback in issue #383 about examples/menu-button/menu-button-actions-active-descendant.html,
made the following changes.

1. Per feedback from @annabbott, Removed documentation of space key behavior. It is optional. It can be restored if appropriate after issue #403 is resolved.
2. Adjusted grammar in keyboard table to be consistent with similar changes made for issue #384 in commit c4d70e8.
mcking65 added a commit that referenced this issue Jun 19, 2017
@mcking65
Actions Menu Button Example Using aria-activedescendant: Remove revie…
651d3a3 
…w issue link to complete review process

Removed link to issue #383 from examples/menu-button/menu-button-actions-active-descendant.html.
The internal task force review process is complete.
@mcking65
Copy link
Contributor Author

All feedback has been addressed except for the space key bug, which is being tracked by issue 403. In the mean time, documentation of space key functionality is removed since support for it is optional in the menu. Closing this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

@annabbott annabbott

Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
Jan 2017 Clean Up
Development

No branches or pull requests
5 participants
@jnurthen @mcking65 @shirsha @a11ydoer @annabbott