Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review revised Actions Menu Button Example Using element.focus() #382

Closed
2 of 4 tasks
mcking65 opened this issue Apr 26, 2017 · 5 comments
Closed
2 of 4 tasks

Review revised Actions Menu Button Example Using element.focus() #382

mcking65 opened this issue Apr 26, 2017 · 5 comments
Assignees
Labels
Example Page Related to a page containing an example implementation of a pattern

Comments

@mcking65
Copy link
Contributor

mcking65 commented Apr 26, 2017

The
actions button menu example using element.focus()
has been significantly revised and needs additional task force review

Reviews requested as of April 26, 2017

@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Needs Review labels Apr 26, 2017
@mcking65 mcking65 added this to the Jan 2017 Clean Up milestone Apr 26, 2017
@jnurthen
Copy link
Member

jnurthen commented May 1, 2017

I was going to comment on the fact that you don't set tabindex=0 on the focused node as normally needed when using roaming tabindex but realized that this is completely unnecessary in this example. Looks good.

@annabbott
Copy link

annabbott commented May 1, 2017

Keyboard support > Menu: Space does not perform as documented. It does activate the menu item, causing the "Last Action" textbox to be updated, then momentarily closes and reopens the menu with focus set to Action 1.

Tested using Win10/FF 53.0

@annabbott
Copy link

annabbott commented May 1, 2017

Keyboard support > Menu: A-Z or z-a A-Z and a-z does not perform as expected and there is a typo in the first bullet:
Moves focus to the next menu item with a lable (typo: should be label) that starts with the typed character if such an menu item exists.
Otherwise, focus does not move.

Pressing A-Z and/or z-a does move focus to the typed character, but closes the menu. Same issue as in #384

Tested using Win10/FF 53.0

@annabbott
Copy link

annabbott commented May 1, 2017

"Menu Button Design Pattern in WAI-ARIA Authoring Practices 1.1" at bottom of page has incorrect target. Should be http://w3c.github.io/aria-practices/#menubutton and not https://w3c.github.io/#menubutton

mcking65 added a commit that referenced this issue Jun 19, 2017
…key documentation

To resolve feedback in issue #382 about examples/menu-button/menu-button-actions.html,
made the following changes.

1. Per feedback from @annabbott, Removed documentation of space key behavior. It is optional. It can be restored if appropriate after issue #403 is resolved.
2. Adjusted grammar in keyboard table to be consistent with similar changes made for issue #384 in commit c4d70e8.
3. Per feedback from @annabbott, Fixed href of pattern link in footer.
mcking65 added a commit that referenced this issue Jun 19, 2017
…complete review process

Removed link to issue #382 from examples/menu-button/menu-button-actions.html.
The internal task force review process is now complete.
@mcking65
Copy link
Contributor Author

All feedback has been addressed. The outstanding space key bug is tracked in issue 403. In the mean time, space key documentation has been removed since supporting it is optional in the menu. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Page Related to a page containing an example implementation of a pattern
Development

No branches or pull requests

6 participants