Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOS 14 #55

Merged
merged 1 commit into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,21 @@ jobs:

strategy:
matrix:
os: [windows-2022]
os: [windows-2022, macos-14]
node-version: ['18.x']
test-command:
- npm run test-style
- npm run test-types
- npm run test-unit
exclude:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# The `test-style` script is platform-independent, so there is no
# value in executing it in multiple operating systems.
- os: macos-14
test-command: npm run test-style
# The `test-types` script is platform-independent, so there is no
# value in executing it in multiple operating systems.
- os: macos-14
test-command: npm run test-types

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions lib/commands/serve.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ const createCommandServer = require('../create-command-server');
const createVoiceServer = require('../create-voice-server');

const WINDOWS_NAMED_PIPE = '\\\\?\\pipe\\my_pipe';
const MACOS_SYSTEM_DIR = '/usr/local/var/at_driver_generic';
const MACOS_SOCKET_UNIX_PATH = '/usr/local/var/at_driver_generic/driver.socket';
const MACOS_SYSTEM_DIR = '/tmp/at_driver_generic';
const MACOS_SOCKET_UNIX_PATH = '/tmp/at_driver_generic/driver.socket';
const DEFAULT_PORT = 4382;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class ATDriverClientUnix {
}
}

static let pipe = "/usr/local/var/at_driver_generic/driver.socket"
static let pipe = "/tmp/at_driver_generic/driver.socket"

func sendInitEvent() throws {
try self._sendEvent(name: "lifecycle", data: "hello")
Expand Down
2 changes: 1 addition & 1 deletion test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const WebSocket = require('ws');

const SOCKET_PATH = {
win32: '\\\\?\\pipe\\my_pipe',
darwin: '/usr/local/var/at_driver_generic/driver.socket',
darwin: '/tmp/at_driver_generic/driver.socket',
}[process.platform];

const executable = path.join(__dirname, '..', 'bin', 'at-driver');
Expand Down
Loading