Support macOS 14 #55
Merged
Support macOS 14 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this needs some work--the tests fail in CI but not my development machine. I'm on the case. |
macOS version 14 removed the `/usr/local/var/` directory. `/run/` and `/var/run/` are defined by the Filesystem Hierarchy Standard for the purpose of UNIX-domain sockets [1]. However, macOS 14 does not include `/run/`, and `/var/run/` is not world-writable on that platform. In order to support macOS 14, use the `/tmp/` directory, instead. Extend the configuration of the project's continuous integration environment to include macOS 14. [1] https://refspecs.linuxfoundation.org/FHS_3.0/index.html
Merged
|
This is ready for review, now! |
stalgiag
approved these changes
Jun 6, 2024
| node-version: ['18.x'] | ||
| test-command: | ||
| - npm run test-style | ||
| - npm run test-types | ||
| - npm run test-unit | ||
| exclude: |
jugglinmike
added a commit
to bocoup/at-driver-servers
that referenced
this pull request
Jun 19, 2024
macOS version 14 removed the `/usr/local/var/` directory. `/run/` and `/var/run/` are defined by the Filesystem Hierarchy Standard for the purpose of UNIX-domain sockets [1]. However, macOS 14 does not include `/run/`, and `/var/run/` is not world-writable on that platform. In order to support macOS 14, use the `/tmp/` directory, instead. Extend the configuration of the project's continuous integration environment to include macOS 14. This commit has been cherry-picked from the "aria-at-automation-driver" project, where it was previously reviewed and approved [2]. [1] https://refspecs.linuxfoundation.org/FHS_3.0/index.html [2] w3c/aria-at-automation-driver#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS version 14 removed the
/usr/local/var/directory./run/and/var/run/are defined by the Filesystem Hierarchy Standard for the purpose of UNIX-domain sockets 1. However, macOS 14 does not include/run/, and/var/run/is not world-writable on that platform. In order to support macOS 14, use the/tmp/directory, instead. Extend the configuration of the project's continuous integration environment to include macOS 14.Footnotes
https://refspecs.linuxfoundation.org/FHS_3.0/index.html ↩