-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install and uninstall subcommands #42
Conversation
Add subcommands for installing text to speech extensions and other support software.
@jugglinmike I think we will need to move in this direction of having install as a separate step from npm install in some way. If a user of the package has two copies of the package installed in two locations, trying to install two copies of the voice will cause issues, at least for macos. On macos having two copies of the speech synthesizer extension will not work. One will be selected over the other by the operating system. If we haven't different versions of the extension will further complicate it, where we probably can't set which version will run. What do you think? To a lesser point, I think this change will help with getting the package working in CI sooner for us like with #34. |
Here's how I understand the installation process as implemented on the "main" branch today:
And here's how I understand it will look if we merge this patch:
Is that accurate? If so, how will changing the actor in step 3 allow us to support multiple simultaneous installations? |
This doesn't properly support multiple copies. At minimum I think we'd need to be able to check the version of any installed extension. And a step past that, migrate between versions. But with this PR you could have, for example for developers on the package, a development copy and a globally installed copy. My darwin draft has an I guess part of this is, to me, how |
(This patch is in service of gh-29) |
Add subcommands for installing text to speech extensions and other support software.