Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node test github workflow #34

Merged
merged 13 commits into from
Apr 2, 2024
Merged

Add node test github workflow #34

merged 13 commits into from
Apr 2, 2024

Conversation

mzgoddard
Copy link
Contributor

Run npm test on github actions on windows.

@mzgoddard mzgoddard requested a review from jugglinmike January 30, 2024 17:06
@mzgoddard
Copy link
Contributor Author

@jugglinmike I was trying to debug why the rejects invalid "pressKey" Command test was failing with a mismatch on message: 'Invalid key code specified.'. I realized the main branch is also failing.

@mzgoddard
Copy link
Contributor Author

The current failure in the workflow is in npm ci. The postinstall script is failing since MakeVoice doesn't exist in the CI environment.

Hmm.

@jugglinmike
Copy link
Contributor

The current failure in the workflow is in npm ci. The postinstall script is failing since MakeVoice doesn't exist in the CI environment.

Hmm.

We can still execute the tests even if the npm ci step fails for that reason. How about applying the continue-on-error feature to that step for now? Doing so will make it slightly harder to identify failures that result from a problem with installing packages, but compared to the risks of continuing to develop this project without any CI at all, I think that's acceptable.

@mzgoddard
Copy link
Contributor Author

@jugglinmike I rebased onto main and added continue-on-error to npm ci step. I guess the next step would be to run prettier in a different PR or this one. (Or merge this and do that as a follow up.)

@jugglinmike jugglinmike merged commit d46c0a5 into main Apr 2, 2024
6 checks passed
@jugglinmike jugglinmike deleted the ci-npm-test branch April 2, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants