Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pro forma invoice #808

Merged
merged 3 commits into from
Jun 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions docs/credentials-with-issuer-dependent-terms.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
"type": "PurchaseOrderCredential",
"count": 6
},
{
"type": "ProformaInvoiceCredential",
"count": 6
},
{
"type": "ProductRegistrationCredential",
"count": 0
Expand Down Expand Up @@ -225,7 +221,7 @@
},
{
"type": "CommercialInvoiceCredential",
"count": 6
"count": 8
},
{
"type": "CertificationOfOrigin",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ properties:
type: string
enum:
- Invoice
isProforma:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is poor JSON-LD

title: is Pro Forma
description: Indicates if this credential is a Pro Forma Invoice, or a normal invoice.
type: boolean
identifier:
title: Property Identifier
description: Identifiers for a property.
Expand Down Expand Up @@ -697,8 +701,6 @@ properties:
additionalProperties: false
required:
- type
- unitCode
- value
productPrice:
title: Product Price
description: >-
Expand Down Expand Up @@ -840,8 +842,6 @@ properties:
additionalProperties: false
required:
- type
- unitCode
- value
grossWeight:
title: Trade Line Item Gross Weight
description: >-
Expand Down Expand Up @@ -877,8 +877,6 @@ properties:
additionalProperties: false
required:
- type
- unitCode
- value
lineItemTotalPrice:
title: Total Price
description: Total line item price.
Expand Down Expand Up @@ -963,8 +961,6 @@ properties:
additionalProperties: false
required:
- type
- unitCode
- value
termsOfDelivery:
title: Terms of Delivery
description: The conditions agreed upon between the parties with regard to the delivery of goods and or services.
Expand Down Expand Up @@ -1239,7 +1235,9 @@ properties:
'@id': https://schema.org/priceCurrency
additionalProperties: false
required:
- type
- type
- price
- priceCurrency
additionalProperties: false
required:
- type
Expand Down Expand Up @@ -1321,6 +1319,7 @@ example: |-
],
"unLocode": "USLGB"
},
"isProforma": false,
"destinationCountry": "MX",
"purchaseDate": "2021-02-21",
"seller": {
Expand Down Expand Up @@ -1489,9 +1488,9 @@ example: |-
},
"proof": {
"type": "Ed25519Signature2018",
"created": "2023-06-06T13:03:46Z",
"created": "2023-06-13T12:41:18Z",
"verificationMethod": "did:key:z6MktHQo3fRRohk44dsbE76CuiTpBmyMWq2VVjvV6aBSeE3U#z6MktHQo3fRRohk44dsbE76CuiTpBmyMWq2VVjvV6aBSeE3U",
"proofPurpose": "assertionMethod",
"jws": "eyJhbGciOiJFZERTQSIsImI2NCI6ZmFsc2UsImNyaXQiOlsiYjY0Il19..SRBoQfZDVwgKQoKPqxpagReysreaN5dEkAqKvgIbfndppxbHZPbftZCwWwsnIzxelK-5rr8cempmVL2ng3azAw"
"jws": "eyJhbGciOiJFZERTQSIsImI2NCI6ZmFsc2UsImNyaXQiOlsiYjY0Il19..YA9ft8yEDfIHVNPfiZX_GQsyI6cuo-_KQq3WNX-N8nH8EX-Nw8sXIzEvkIaxmGyXmLZFzRQe9PdKo5fvzO2LAA"
}
}

This file was deleted.