Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pro forma invoice #808

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Remove pro forma invoice #808

merged 3 commits into from
Jun 13, 2023

Conversation

BenjaminMoe
Copy link
Contributor

@BenjaminMoe BenjaminMoe commented Jun 13, 2023

Updating credentials from feedback

  • Remove pro forma invoice
  • Add flag to commercial invoice to indicate pro forma or not

@BenjaminMoe BenjaminMoe marked this pull request as ready for review June 13, 2023 12:47
Copy link
Collaborator

@mkhraisha mkhraisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one supersedes #805?

@mkhraisha mkhraisha mentioned this pull request Jun 13, 2023
@@ -175,6 +175,10 @@ properties:
type: string
enum:
- Invoice
isProforma:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is poor JSON-LD

@nissimsan nissimsan merged commit 42574fc into main Jun 13, 2023
@BenjaminMoe BenjaminMoe deleted the remove-pro-forma-invoice branch June 13, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants