-
-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[lang]: fix precedence in floordiv hint #4203
Merged
charles-cooper
merged 10 commits into
vyperlang:master
from
cyberthirst:fix/braces-in-hints
Aug 6, 2024
Merged
fix[lang]: fix precedence in floordiv hint #4203
charles-cooper
merged 10 commits into
vyperlang:master
from
cyberthirst:fix/braces-in-hints
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't need to handle braces for vyper/vyper/semantics/types/primitives.py Line 221 in 767f2da
|
Co-authored-by: Charles Cooper <[email protected]>
charles-cooper
approved these changes
Aug 5, 2024
charles-cooper
changed the title
fix[lang]: fix braces for division hint
fix[lang]: fix parentheses for floordiv hint
Aug 6, 2024
charles-cooper
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
charles-cooper
changed the title
fix[lang]: fix parentheses for floordiv hint
fix[lang]: fix parentheses in floordiv hint
Aug 6, 2024
charles-cooper
changed the title
fix[lang]: fix parentheses in floordiv hint
fix[lang]: fix precedence in floordiv hint
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Commit Message