fix braces for division hint

vyperlang · Aug 2, 2024 · 767f2da · 767f2da
1 parent 99304da
commit 767f2da
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/vyper/ast/nodes.py b/vyper/ast/nodes.py
@@ -411,6 +411,10 @@ def has_folded_value(self):
         """
         return "folded_value" in self._metadata
 
+    @property
+    def is_leaf(self):
+        return not self._children
+
     def get_folded_value(self) -> "ExprNode":
         """
         Attempt to get the folded value, bubbling up UnfoldableNode if the node

diff --git a/vyper/ast/nodes.pyi b/vyper/ast/nodes.pyi
@@ -35,6 +35,8 @@ class VyperNode:
     def has_folded_value(self): ...
     @property
     def parent(self): ...
+    @property
+    def is_leaf(self): ...
     @classmethod
     def get_fields(cls: Any) -> set: ...
     def set_parent(self, parent: VyperNode) -> VyperNode: ...

diff --git a/vyper/semantics/types/primitives.py b/vyper/semantics/types/primitives.py
@@ -211,9 +211,13 @@ def _add_div_hint(node, e):
     else:
         return e
 
+    def get_source(node):
+        source = node.node_source_code
+        return source if node.is_leaf else f"({source})"
+
     if isinstance(node, vy_ast.BinOp):
-        e._hint = f"did you mean `{node.left.node_source_code} "
-        e._hint += f"{suggested} {node.right.node_source_code}`?"
+        e._hint = f"did you mean `{get_source(node.left)} "
+        e._hint += f"{suggested} {get_source(node.right)}`?"
     elif isinstance(node, vy_ast.AugAssign):
         e._hint = f"did you mean `{node.target.node_source_code} "
         e._hint += f"{suggested}= {node.value.node_source_code}`?"