Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start custom message keysign #772

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Start custom message keysign #772

merged 9 commits into from
Jan 15, 2025

Conversation

rcoderdev
Copy link
Collaborator

No description provided.

- Introduced a new SignatureIcon component in the UI library.
- The component renders an SVG icon representing a signature, enhancing the visual elements available for use in the application.
- Introduced SignCustomMessagePage component for signing custom messages.
- Updated router to include a new route for the SignCustomMessagePage.
- Added new translation key for 'Sign custom message' in English locale.
- Updated appPaths to include the path for the SignCustomMessagePage.
- Enhanced edit vault settings to include an entry for signing custom messages with the new SignatureIcon.
…ates

- Added translation for 'Sign message' in English locale.
- Updated SignCustomMessagePage to utilize the new translation and improved layout with FlowPageHeader and PageContent components.
- Adjusted styling in EditVaultPage to increase font size for better visibility of icons.
…e management

- Added new translation keys for required fields in English locale.
- Updated SignCustomMessagePage to include state management for method and message inputs.
- Implemented form validation to disable the submit button when required fields are empty.
- Enhanced the form submission process to navigate with the custom message payload.
…state management

- Refactored DepositConfirmButton and StartKeysignPrompt components to encapsulate keysignPayload within a nested object.
- Enhanced SignCustomMessagePage to manage method and message states, improving user input handling.
- Streamlined StartKeysignPage and StartFastKeysignPage by removing unnecessary KeysignPayloadProvider, simplifying the component structure.
- Updated WailsJS type definitions for better consistency and readability across the application.
…omponents

- Added a new utility function `getRecordUnionValue` to extract values from record unions, enhancing type safety and code reusability.
- Removed the obsolete `QRGen.ts` file, streamlining the codebase.
- Introduced `customMessageConfig` for managing custom message settings in keysigning.
- Refactored `JoinKeysignPage`, `KeysignTxOverview`, and related components to utilize the new `keysignMessagePayload` context, improving state management and component structure.
- Eliminated the deprecated `joinKeysignMessagePayload` hook, simplifying the data flow in keysigning processes.
- Updated various components to ensure consistent usage of the new payload structure, enhancing maintainability and clarity.
- Added new translation keys for 'Sign custom message', 'Sign message', 'Method required', and 'Message required' in German, Spanish, Croatian, Italian, and Portuguese locales.
- Enhanced localization support for the SignCustomMessagePage, improving accessibility for users in different languages.
…navigation state

- Eliminated the `keysignAction` property from the keysigning state and related components, simplifying the payload structure.
- Updated `DepositConfirmButton`, `StartKeysignPage`, and `KeysignPeerDiscoveryStep` to reflect the removal of `keysignAction`, enhancing clarity and maintainability.
- Streamlined navigation state management by focusing on the essential `keysignPayload` object.
@rcoderdev rcoderdev changed the title WIP: Start custom message keysign Start custom message keysign Jan 15, 2025
@rcoderdev rcoderdev marked this pull request as ready for review January 15, 2025 03:28
Copy link
Collaborator

@antoni0dev antoni0dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@johnnyluo johnnyluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyluo johnnyluo merged commit 6ae0c7e into main Jan 15, 2025
2 checks passed
@antoni0dev antoni0dev deleted the feat/custom-msg branch January 15, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants