Fix "join keysign for ERC20 swaps" by eliminating the dependency on the order of signatures. #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new utility function `recordFromItems` to convert an array of items into a record based on a provided key extraction function. - Refactored `useKeysignMutation` to utilize `recordFromItems` for creating a signatures record, improving code clarity and maintainability. - Updated `ScanQrView` to include error message extraction using `extractErrorMsg`, enhancing error handling in the component.
antoni0dev
force-pushed
the
fix/keysign
branch
from
59908fa to
daf1a60
Compare
antoni0dev
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.