Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [#582] - resolving random HMR port - better solution #590

Merged
merged 1 commit into from
Jun 17, 2018
Merged

fix [#582] - resolving random HMR port - better solution #590

merged 1 commit into from
Jun 17, 2018

Conversation

r3stm4n
Copy link
Contributor

@r3stm4n r3stm4n commented Jun 14, 2018

Summary
Port from cli/options can be string, so parseInt is required.
Two cases (--port 23300):

  1. if port is already taken then without parseInt resolvePort will return 230001 (should be 23001)
  2. if port is string HMR port will be 230001 (should be 23001)

Please revert previous merge #586
This is better solution.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

ulivz added a commit that referenced this pull request Jun 17, 2018
- Revert is because there is a better solution at #590

This reverts commit 64bb80d.
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit 5afff6f into vuejs:master Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants