Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random port for websocket on dev - HMR #582

Closed
r3stm4n opened this issue Jun 13, 2018 · 0 comments
Closed

random port for websocket on dev - HMR #582

r3stm4n opened this issue Jun 13, 2018 · 0 comments

Comments

@r3stm4n
Copy link
Contributor

r3stm4n commented Jun 13, 2018

Bug report

running command vuepress dev --port 23300 --host myhost.com docs
should:
listen on 23300 - http
listen on 23301 - HMR (according to https://github.com/vuejs/vuepress/blob/master/lib/dev.js#L105)

but HMR port is random (every run)

Version

0.10.1

Steps to reproduce

run command vuepress dev --port 23300 --host myhost.com docs

What is expected?

port + 1 or provided by options
(according to https://github.com/vuejs/vuepress/blob/master/lib/dev.js#L105)

What is actually happening?

random port for HMR

Other relevant information

  • Your OS: Centos7 (server) Linux Mint 18 (client) (on local Mint same problem)
  • Node.js version: v8.11.2
  • Browser version: Firefox 60.0.1
  • Is this a global or local install? Local
  • Which package manager did you use for the install? yarn v1.6.0

screenshot from 2018-06-13 19-34-08

@ulivz ulivz closed this as completed in 64bb80d Jun 14, 2018
ulivz added a commit that referenced this issue Jun 17, 2018
- Revert is because there is a better solution at #590

This reverts commit 64bb80d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant