Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($docs): Sync changes in Chinese & Translate docs-'local development' #1915

Merged
merged 10 commits into from
Oct 7, 2019
Merged

feat($docs): Sync changes in Chinese & Translate docs-'local development' #1915

merged 10 commits into from
Oct 7, 2019

Conversation

Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Oct 5, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@Mister-Hope Mister-Hope changed the title Zh cn sync feat($docs): Sync changes in Chinese & Translate docs-'local development' Oct 5, 2019
@Mister-Hope
Copy link
Contributor Author

It is almost the same as #1882 , with two more sync on translate and space problem solved.

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some small tweaks

packages/docs/docs/zh/miscellaneous/local-development.md Outdated Show resolved Hide resolved
packages/docs/docs/zh/miscellaneous/local-development.md Outdated Show resolved Hide resolved
@Mister-Hope
Copy link
Contributor Author

FIxed! 😄

@ulivz
Copy link
Member

ulivz commented Oct 7, 2019

After I seriously review the translation, I can basically confirmed that this is modified from the translation from Google.

I hope you will translate it carefully by yourself next time. Thank you.

Also, the commit message should start with docs($cn): instead of feat.

@ulivz ulivz merged commit 9225ff6 into vuejs:master Oct 7, 2019
@vue-bot
Copy link

vue-bot commented Oct 7, 2019

Thanks again! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants