Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($docs): Sync changes in Chinese #1882

Closed
wants to merge 7 commits into from
Closed

feat($docs): Sync changes in Chinese #1882

wants to merge 7 commits into from

Conversation

Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Sep 22, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

The `next` flag seems like an artifact for those who are not on the latest VuePress. Since we are on VuePress 1.0, this should not be the default install path
@Mister-Hope
Copy link
Contributor Author

I will work on the local-development page tomorrow

@ulivz
Copy link
Member

ulivz commented Sep 22, 2019

Cool, tell me if this PR is ready.

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Sep 22, 2019

I will call someone to have another look later.
It’s 0:45 here 😄

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Sep 23, 2019

I think it's ready 😄, my friend helped checking the translation

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本上都是空格的问题,你修复后我再看一下~

packages/docs/docs/zh/miscellaneous/local-development.md Outdated Show resolved Hide resolved
packages/docs/docs/zh/miscellaneous/local-development.md Outdated Show resolved Hide resolved
packages/docs/docs/zh/miscellaneous/local-development.md Outdated Show resolved Hide resolved
@Mister-Hope
Copy link
Contributor Author

🤣 突然发现你的地址杭州,那我还说什么英文
好的我改一下

@kefranabg kefranabg changed the title docs:Sync Changes in Chinese feat($docs): Sync changes in Chinese Sep 24, 2019
@Mister-Hope
Copy link
Contributor Author

基本上都是空格的问题,你修复后我再看一下~

Fixed a few days ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants