Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch to @node-ipc/compat #7063

Closed
wants to merge 3 commits into from
Closed

fix: switch to @node-ipc/compat #7063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c44abc6
fix: switch to @node-ipc/node-ipc
AaronDewes Mar 18, 2022
30cc384
fix: use named export
AaronDewes Mar 18, 2022
796ea31
fix: switch to @node-ipc/compat
AaronDewes Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@vue/cli-shared-utils/lib/ipc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const ipc = require('node-ipc')
const ipc = require('@node-ipc/compat')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaby add a little comment explaning why the node ipc has been replace


const DEFAULT_ID = process.env.VUE_CLI_IPC || 'vue-cli'
const DEFAULT_IDLE_TIMEOUT = 3000
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-shared-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"launch-editor": "^2.2.1",
"lru-cache": "^6.0.0",
"node-fetch": "^2.6.7",
"node-ipc": "9.2.1",
"@node-ipc/compat": "^9.2.3",
"open": "^8.0.2",
"ora": "^5.3.0",
"read-pkg": "^5.1.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-ui/apollo-server/util/ipc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const ipc = require('node-ipc')
const ipc = require('@node-ipc/compat')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaby add a little comment here too explaning why the node ipc has been replace

// Utils
const { log, dumpObject } = require('../util/logger')

Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"lodash.merge": "^4.6.1",
"lowdb": "^1.0.0",
"lru-cache": "^6.0.0",
"node-ipc": "9.2.1",
"@node-ipc/compat": "^9.2.3",
"node-notifier": "^10.0.0",
"parse-git-config": "^3.0.0",
"portfinder": "^1.0.26",
Expand Down
46 changes: 23 additions & 23 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2824,6 +2824,15 @@
pathval "1.1.1"
type-detect "4.0.5"

"@node-ipc/compat@^9.2.3":
version "9.2.3"
resolved "https://registry.yarnpkg.com/@node-ipc/compat/-/compat-9.2.3.tgz#1cc875f3b44ae93fca3f87de261da390b24a55e3"
integrity sha512-2ZH3Uip7yDzeLiKvINxsi5wkhx+ni4Mcs30B2xS6ipMqB/X20scxyQO/5D26r1xVOu+QMuZFxfddUOf6U3PoDg==
dependencies:
event-pubsub "4.2.3"
js-message "1.0.5"
js-queue "2.0.0"

"@nodelib/[email protected]":
version "2.1.5"
resolved "https://registry.yarnpkg.com/@nodelib/fs.scandir/-/fs.scandir-2.1.5.tgz#7619c2eb21b25483f6d167548b4cfd5a7488c3d5"
Expand Down Expand Up @@ -8622,7 +8631,7 @@ duplexer@^0.1.1, duplexer@^0.1.2, duplexer@~0.1.1:
resolved "https://registry.yarnpkg.com/duplexer/-/duplexer-0.1.2.tgz#3abe43aef3835f8ae077d136ddce0f276b0400e6"
integrity sha512-jtD6YG370ZCIi/9GTaJKQxWTZD045+4R4hTk/x1UyoqadyJ9x9CgSi1RlVDQF8U2sxLLSnFkCaMihqljHIWgMg==

easy-stack@^1.0.1:
easy-stack@^1.0.0:
version "1.0.1"
resolved "https://registry.yarnpkg.com/easy-stack/-/easy-stack-1.0.1.tgz#8afe4264626988cabb11f3c704ccd0c835411066"
integrity sha512-wK2sCs4feiiJeFXn3zvY0p41mdU5VUgbgs1rNsc/y5ngFUijdWd+iIN8eoyuZHKB8xN6BL4PdWmzqFmxNg6V2w==
Expand Down Expand Up @@ -9412,10 +9421,10 @@ event-emitter@^0.3.5:
d "1"
es5-ext "~0.10.14"

event-pubsub@4.3.0:
version "4.3.0"
resolved "https://registry.yarnpkg.com/event-pubsub/-/event-pubsub-4.3.0.tgz#f68d816bc29f1ec02c539dc58c8dd40ce72cb36e"
integrity sha512-z7IyloorXvKbFx9Bpie2+vMJKKx1fH1EN5yiTfp8CiLOTptSYy1g8H4yDpGlEdshL1PBiFtBHepF2cNsqeEeFQ==
event-pubsub@4.2.3:
version "4.2.3"
resolved "https://registry.yarnpkg.com/event-pubsub/-/event-pubsub-4.2.3.tgz#0d3142f47ac7e0da38cdc38402d97e2510bc5ecc"
integrity sha1-DTFC9HrH4No4zcOEAtl+JRC8Xsw=

event-stream@=3.3.4:
version "3.3.4"
Expand Down Expand Up @@ -12821,17 +12830,17 @@ js-beautify@^1.6.12:
glob "^7.1.3"
nopt "^5.0.0"

[email protected].7:
version "1.0.7"
resolved "https://registry.yarnpkg.com/js-message/-/js-message-1.0.7.tgz#fbddd053c7a47021871bb8b2c95397cc17c20e47"
integrity sha512-efJLHhLjIyKRewNS9EGZ4UpI8NguuL6fKkhRxVuMmrGV2xN/0APGdQYwLFky5w9naebSZ0OwAGp0G6/2Cg90rA==
[email protected].5:
version "1.0.5"
resolved "https://registry.yarnpkg.com/js-message/-/js-message-1.0.5.tgz#2300d24b1af08e89dd095bc1a4c9c9cfcb892d15"
integrity sha1-IwDSSxrwjondCVvBpMnJz8uJLRU=

[email protected].2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/js-queue/-/js-queue-2.0.2.tgz#0be590338f903b36c73d33c31883a821412cd482"
integrity sha512-pbKLsbCfi7kriM3s1J4DDCo7jQkI58zPLHi0heXPzPlj0hjUsm+FesPUbE0DSbIVIK503A36aUBoCN7eMFedkA==
[email protected].0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/js-queue/-/js-queue-2.0.0.tgz#362213cf860f468f0125fc6c96abc1742531f948"
integrity sha1-NiITz4YPRo8BJfxslqvBdCUx+Ug=
dependencies:
easy-stack "^1.0.1"
easy-stack "^1.0.0"

"js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0:
version "4.0.0"
Expand Down Expand Up @@ -14919,15 +14928,6 @@ node-int64@^0.4.0:
resolved "https://registry.yarnpkg.com/node-int64/-/node-int64-0.4.0.tgz#87a9065cdb355d3182d8f94ce11188b825c68a3b"
integrity sha1-h6kGXNs1XTGC2PlM4RGIuCXGijs=

[email protected]:
version "9.2.1"
resolved "https://registry.yarnpkg.com/node-ipc/-/node-ipc-9.2.1.tgz#b32f66115f9d6ce841dc4ec2009d6a733f98bb6b"
integrity sha512-mJzaM6O3xHf9VT8BULvJSbdVbmHUKRNOH7zDDkCrA1/T+CVjq2WVIDfLt0azZRXpgArJtl3rtmEozrbXPZ9GaQ==
dependencies:
event-pubsub "4.3.0"
js-message "1.0.7"
js-queue "2.0.2"

node-notifier@^10.0.0:
version "10.0.1"
resolved "https://registry.yarnpkg.com/node-notifier/-/node-notifier-10.0.1.tgz#0e82014a15a8456c4cfcdb25858750399ae5f1c7"
Expand Down