-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: switch to @node-ipc/compat #7063
Conversation
Looks like there's another Just for reference, I'm also maintaining my own fork for v9 and v10/v11 here: achrinza/node-ipc#1 |
@@ -1,4 +1,4 @@ | |||
const ipc = require('node-ipc') | |||
const ipc = require('@node-ipc/compat') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaby add a little comment explaning why the node ipc has been replace
@@ -1,4 +1,4 @@ | |||
const ipc = require('node-ipc') | |||
const ipc = require('@node-ipc/compat') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaby add a little comment here too explaning why the node ipc has been replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has a i said in comment, we could add a little comment explaining why the depedency has change.
@node-ipc/compat seems like just a backported version of node-ipc (@node-ipc/node-ipc) not a fork. I could be wrong though. If this is true, might be a better option to choose a third-party fork like achrinza's, because the author of node-ipc could add the patch to @node-ipc/compat |
@DumbGameMaker They're all third-party forks of the original package
The FAQ provides more info on the difference. |
Hi, thank you for all the help here! After reading the FAQ section by @achrinza and reviewing the two projects, I decided to use It's not that the other fork isn't good. And Vue CLI doesn't need any new feature from Thanks again! |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
This pull request switches to @node-ipc/compat, a fork of node-ipc without malware.