fix: click event triggered twice leads to repeated execution of the router.go method #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonemeen
changed the title
zonemeen
changed the title
zonemeen
changed the title
brc-dd
reviewed
Jul 15, 2022
| event.preventDefault() | ||
| } | ||
|
|
||
| router.go(relativeHit) |
There was a problem hiding this comment.
If we are removing these then there is no need to provide the onClick prop, there is nothing being done there except for this. If I am correct, then we can remove that safely as this part of the code handles all the links. Might need to discuss this first with others.
There was a problem hiding this comment.
Hi @brc-dd , have you discussed the solution yet?
|
Sry, this PR was accidentally closed by me😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #995