Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated execution of the router.go method when clicking on the jump link in the Algolia search box #995

Closed
3 tasks done
zonemeen opened this issue Jul 15, 2022 · 0 comments · Fixed by #1087
Closed
3 tasks done

Repeated execution of the router.go method when clicking on the jump link in the Algolia search box #995

zonemeen opened this issue Jul 15, 2022 · 0 comments · Fixed by #1087
Labels
bug Something isn't working theme Related to the theme

Comments

@zonemeen
Copy link
Collaborator

zonemeen commented Jul 15, 2022 •
edited
Loading

Describe the bug

Repeated execution of the go method in src/client/app/router.ts and src/client/theme-default/components/VPAlgoliaSearchBox.vue when clicking on the jump link in the Algolia search box results in the need to click back key twice to return to the before page.

click-back- twice-bug

Reproduction

https://vitepress.vuejs.org/

Expected behavior

Click back key once to return to the before page.

System Info

System:
    OS: Windows 10
    CPU: Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz
    Memory: 15.9 GB
  Binaries:
    Node: 16.10.0
    Yarn: 1.22.17
    npm: 7.24.0
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (103.0.5060.114)
    Internet Explorer: 11.0.22000.120

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@zonemeen zonemeen added the bug: pending triage Maybe a bug, waiting for confirmation label Jul 15, 2022
@zonemeen zonemeen mentioned this issue Jul 15, 2022
Closed
@zonemeen zonemeen changed the title Repeated execution of the go method in createRouter when clicking on the jump link in the Algolia search box Repeated execution of the router.go method when clicking on the jump link in the Algolia search box Jul 15, 2022
@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Jul 15, 2022
@brc-dd brc-dd mentioned this issue Jul 29, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
Milestone
No milestone
2 participants
@brc-dd @zonemeen