fix: prevent line numbers from being copied. Closes #884 #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
megasanjay
changed the title
megasanjay
changed the title
|
Hi! Thanks for the PR. But I had changed the code copying logic in #875. It appears to be fixed there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue where having line numbers enabled in your markdown causes the
copy to clipboardbutton to also add in those line numbers at the end.This PR now looks at the
<code>tag to read theinnertextcontents. This skips the line numbers from being added to the copied text.Tested locally with
lineNumbersboth enabled and disabled.