Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to clipboard feature also adding line numbers #884

Closed
3 tasks done
megasanjay opened this issue Jul 1, 2022 · 1 comment
Closed
3 tasks done

Copy to clipboard feature also adding line numbers #884

megasanjay opened this issue Jul 1, 2022 · 1 comment
Labels
bug Something isn't working build Related to the build system

Comments

@megasanjay
Copy link

Describe the bug

This is an issue with the Vitepress alpha version. We have some code blocks with line numbers enabled in markdown. It would appear that using the copy to clipboard button is also somehow grabbing the line numbers along with it.

Reproduction

Attaching our docs link here: https://dev.fairdataihub.org/docs/README.html#tech-stack
You can click on the copy to clipboard button to try it out

Expected behavior

Only the code block content should be copied.

System Info

System:
    OS: Windows 10 10.0.22000
    CPU: (20) x64 Intel(R) Core(TM) i9-10900K CPU @ 3.70GHz
    Memory: 16.33 GB / 31.81 GB
  Binaries:
    Node: 16.14.2 - ~\anaconda3\envs\nuxt-env\node.EXE
    Yarn: 1.22.11 - ~\anaconda3\envs\nuxt-env\yarn.CMD
    npm: 8.12.2 - ~\Desktop\fairdataihub-docs\node_modules\.bin\npm.CMD
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (103.0.1264.37)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    vitepress: 1.0.0-alpha.4 => 1.0.0-alpha.4

Not sure if these are correct since I'm on windows 11...

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@megasanjay megasanjay added the bug: pending triage Maybe a bug, waiting for confirmation label Jul 1, 2022
megasanjay pushed a commit to megasanjay/vitepress that referenced this issue Jul 1, 2022
@megasanjay
Copy link
Author

megasanjay commented Jul 1, 2022

Added a PR that fixes this issue in #886

@brc-dd brc-dd added bug Something isn't working build Related to the build system and removed bug: pending triage Maybe a bug, waiting for confirmation labels Jul 1, 2022
megasanjay added a commit to fairdataihub/dev.fairdataihub.org that referenced this issue Jul 8, 2022
@brc-dd brc-dd closed this as completed in f789932 Jul 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working build Related to the build system
Projects
None yet
Development

No branches or pull requests

2 participants