Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add code-group title #1969

Closed
wants to merge 5 commits into from
Closed

feat: add code-group title #1969

wants to merge 5 commits into from

Conversation

lavecoral
Copy link

Add same custom title as custom container to code group

@MarkusKeck
Copy link
Collaborator

MarkusKeck commented Feb 21, 2023

Isn't this the same as #1834

It got added in the latest version 1.0.0-alpha.47 (2023-02-20)
https://github.com/vuejs/vitepress/blob/main/CHANGELOG.md

It is already documented on the vitepress website
https://vitepress.vuejs.org/guide/markdown#code-groups

@brc-dd
Copy link
Member

brc-dd commented Feb 21, 2023

@MarkusKeck No, this one adds something like a caption to a code-block:

image

I am still not sure if we'll be adding this though. For images this might make sense, but for code groups/blocks I don't think this has any use case.

@MarkusKeck
Copy link
Collaborator

@brc-dd Thanks for clarification, I also dont really see a usecase, if you want the whole filename you can just add it to the title.

@MarkusKeck
Copy link
Collaborator

@lavecoral Some of the tests have failed. You can check this manually before pushing:

pnpm check

If something is not formatted correctly run: prettier --check .
After that prettier --write <filename>

@lavecoral
Copy link
Author

@lavecoral lavecoral closed this Feb 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants