-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom titles of code snippets inside code groups #1834
Conversation
when would it be merged, i need this feature |
@brc-dd, please take a look at this 🙏 It's a small fix, but oh so useful |
I would also appreciate if this gets merged. Example (Changed ` for ' so it gets displayed correctly) '''java [<i class="fa-sharp fa-solid fa-flag-checkered"></i> Alternate Solution]
... content
''' |
@MarkusKeck, technically the regex doesn't disallow the markup inside the This PR's code simply passes the parsed title to already existing logic for processing. |
@Raiondesu Even better. I really like the approach and implementation. It will make my project much cleaner. At the moment I am using a "workaround" which allows me to externalize my snippets but also allows me to change the displayed name.
Inside every file I have to add the codetab markup (see example above). It is not really pretty but the only way I could figure out to make this work. Looking forward to getting this merged. Thanks for the implementation. |
@MarkusKeck, thanks! I believe the regex you mentioned was actually changed to |
@brc-dd, what's keeping this from being merged? |
Thank you @brc-dd |
Thank you! @Raiondesu @brc-dd |
This PR fixes #1785, by allowing the following syntax when a snippet is placed in a code group:
See updated docs for an example.