feat: support themable images for logo and hero #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
reviewed
Jun 17, 2022
brc-dd
reviewed
Jun 17, 2022
brc-dd
added a commit
that referenced
this pull request
Jun 17, 2022
* refactor: refine global layout system * chore: remove unknown console log from release script * release: v1.0.0-alpha.2 * docs: add Layer0 deployment notes Co-authored-by: meteorlxy <[email protected]> * docs: add cloudflare pages deploy (#797) close #369 Co-authored-by: Kia King Ishii <[email protected]> * refactor: improve site data parsing (#780) * fix: copy code in non-secure contexts (#792) Co-authored-by: Divyansh Singh <[email protected]> * fix(theme): add italic fonts (#759) (#777) fix #759 * docs: image migration guide for vuepress (#799) * refactor(types): use built-in utility type `Awaited` (#801) instead of explicitly defining it. (introduced in TS 4.5) * feat(theme): support themeable images for logo and hero (#745) Co-authored-by: Divyansh Singh <[email protected]> Co-authored-by: Kia King Ishii <[email protected]> Co-authored-by: Rishi Raj Jain <[email protected]> Co-authored-by: meteorlxy <[email protected]> Co-authored-by: Percy Ma <[email protected]> Co-authored-by: Linmj <[email protected]> Co-authored-by: JD Solanki <[email protected]> Co-authored-by: CHOYSEN <[email protected]> Co-authored-by: Anthony Fu <[email protected]>
4 tasks
rijkvanzanten
added a commit
to rijkvanzanten/vitepress
that referenced
this pull request
Aug 10, 2022
vuejs#745 added support for a light vs dark mode logo, but according to vuejs#1006 (comment) was never documented. I figured a tweak to the docs would be a good first contribution to the project 🤩
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the logo and hero icon to be provided with light and dark versions.
config.ts
index.html