docs: add different logos for light and dark modes #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuejs#745 added support for a light vs dark mode logo, but according to vuejs#1006 (comment) was never documented. I figured a tweak to the docs would be a good first contribution to the project 🤩
brc-dd
changed the title
rijkvanzanten
commented
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#745 added support for a light vs dark mode logo by setting the
logoconfiguration. According to @brc-dd in #1006 (comment), it's officially supported but not documented yet. Seeing it's a super useful configuration, I figured it was a good first contribution to the project 🙂Please let me know if I correctly understood the setup for the "Type" description. Happy to make any changes where needed 👍🏻
Closes #1006 1.
Footnotes
1006 is the open feature request for adding light/dark mode support in the logo. It already exists, so I think the issue was left open as a reminder to add it to the docs, which is why this PR should close it. ↩