Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(zh): sync getting started page at 3ab1e5e #2234

Merged
merged 6 commits into from
May 15, 2024
Merged

doc(zh): sync getting started page at 3ab1e5e #2234

merged 6 commits into from
May 15, 2024

Conversation

GYHHAHA
Copy link
Contributor

@GYHHAHA GYHHAHA commented May 12, 2024

The current Chinese version page for getting started is totally different compared to the EN version. User who follow the old introduction steps might get lost or encounter failures, especially using npm install vue-router@4 to manually add dependency rather than setting everything with npm create vue@latest. Hope this will help!

Copy link

netlify bot commented May 12, 2024

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit 444abff
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/6642a3456c8be40008d39154
😎 Deploy Preview https://deploy-preview-2234--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 83 (🔴 down 17 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
packages/docs/zh/guide/index.md Outdated Show resolved Hide resolved
@GYHHAHA
Copy link
Contributor Author

GYHHAHA commented May 14, 2024

@Jinjiang Thanks for your revision! I actually found that most of other pages in EN has already been converted to use SFC, I may launch another 2 PRs, respectively for the Essentials part and the Advanced. Otherwise the contexts for those in ZH could still be misleading.

@Jinjiang
Copy link
Member

@Jinjiang Thanks for your revision! I actually found that most of other pages in EN has already been converted to use SFC, I may launch another 2 PRs, respectively for the Essentials part and the Advanced. Otherwise the contexts for those in ZH could still be misleading.

@GYHHAHA good topic. I usually use the full Chinese translation 单文件组件 since I consider this as the most understandable term. And by this chance, I also saw some other places keep using SFC. So I'd like to get this topic into @vuejs-translations/zh-cn team for more discussion. Thanks.

@Jinjiang Jinjiang merged commit d7a4719 into vuejs:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants