docs: fix dark mode flashing bug #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for pinia-official ready! 🔨 Explore the source changes: 7ced7c4 🔍 Inspect the deploy log: https://app.netlify.com/sites/pinia-official/deploys/6201927ffeef9e00087a56f3 😎 Browse the preview: https://deploy-preview-1032--pinia-official.netlify.app |
theoephraim
commented
Feb 4, 2022
theoephraim
commented
Feb 4, 2022
|
@plitter - fixed! |
posva
changed the title
posva
approved these changes
Feb 7, 2022
Closed
|
I still see it chrome_JXOy2ie1AG.mp4 |
|
@web2033 - have you confirmed its not a cached version of the page? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #686
Currently multiple having multiple browser tabs open to the docs site creates some crazy flickering.
Also reloading the page creates inconsistent behaviour switching between dark/light mode.
This removes a bunch of extra code that was trying to mess with dark mode on page load that from what I can tell, seems unnecessary.
I believe the goal was to get the SSG of the site to include a "light" class on the body tag, but it appears from the current docs site page source that it wasn't actually working anyway...
Also