-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs page flickering #686
Comments
This is happening for me from time to time. Firefox, windows 10. |
It seemed like a weird bug related to SSG + the dark mode from vueuse but I will soon migrate to a different theme that shouldn't have this issue |
As soon as you open more than one tab with the pinia site loaded ... poof, flicker. Also CPU and GPU load spikes up. Clearly some sort of infinite loop thing happening... hopefully not due to using Pinia itself! |
No, it's not related to pinia which are not needed in the docs. Opening devtools and changing the local storage property that sets the theme should allow fixing this. Other strategies are reloading the page after closing the other ones. This will be fixed in the next migration of the docs anyway. |
The flickering bug has been fixed upstream |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
As a temporary workaround, while having only one tab opened with the docs, run this js in the console: localStorage.setItem('pinia-color-scheme', 'dark') // or 'light' if you prefer light theme |
Still happening, see video: pinia-website-flicker.mov |
I'm still getting this too. Was wondering how this feature was enabled anyway since it looks like it's vitepress. I know that Evan mentioned new docs were coming soon, so I assume we're waiting for that release? I see there's a pull request on vitepress to fix: export default theme type & properly type vitepress/theme. |
Still getting this on Chrome 97 (M1 Mac) even after using the temporary localStorage workaround. |
https://streamable.com/zf57tl you can see the switch back and forth when you do inspect... A little bit surprised that this is still happening. |
Please expedite addressing this if possible as it does not meet the W3C WCAG 2.0 specifications to not allow Three Flashes or Below Threshold. This is a potential health concern for those with epilepsy or a neurological condition that can easily trigger seizures. https://www.w3.org/TR/UNDERSTANDING-WCAG20/seizure-does-not-violate.html |
Ill give it a go today. Don’t expect it’s too tough to track down. |
Not only does the page flicker, it eats up 100% CPU on all cores, rendering the entire browser useless. I had to disable JavaScript globally for this to settle down (why do doc sites even need JS??) |
Reproduction
Using latest chrome on a mac, open 2 tabs to https://pinia.esm.dev/ and the page starts flickering weirdly.
I can see it's caused by the dark mode flipping on and off rapidly.
I assume it has something to do with how dark mode selection is being saved in localstorage.
The text was updated successfully, but these errors were encountered: