fix(runtime-core): allow spying on proxy methods #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cexbrayat
force-pushed
the
fix/spy-on-proxy
branch
from
ba8fc35 to
b0bc208
Compare
|
This is now rebased on top of #4472 Would be glad to hear your thoughts @yyx990803 as landing this would unblock the ecosystem to move to jest v27 |
cexbrayat
force-pushed
the
fix/spy-on-proxy
branch
2 times, most recently
from
9f23312 to
2d063f8
Compare
|
Now that #4472 landed, this PR is rebased on master and ready to review. The fix is intended to unblock the migration of the ecosystem to jest 27, but it also fixes a more general issue with updating proxies via |
lmiller1990
approved these changes
Nov 30, 2021
LinusBorg
approved these changes
Dec 5, 2021
LinusBorg
added
❗ p4-important
Since Jest v26.6.1, the mock method changed (see this commit jestjs/jest@30e8020) to rely on `Object.defineProperty` in some cases. This breaks spying on proxy's methods, because even if Jest is properly calling `Object.defineProperty`, the cached value in the `get` section of the proxy is never updated, and the spy is in fact never used. This is easily reproducible as vue-next already uses a version of jest with these changes. This is blocking projects (like vue-test-utils-next and vue-cli) to update to recent Jest versions. This commit adds a `defineProperty` method to the proxy handler, that properly updates the defined value in the cache.
cexbrayat
force-pushed
the
fix/spy-on-proxy
branch
from
2d063f8 to
c4c9903
Compare
lidlanca
added a commit
to lidlanca/vue-next
that referenced
this pull request
Feb 12, 2022
yyx990803
pushed a commit
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Jest v26.6.1, the mock method changed (see this commit jestjs/jest@30e8020) to rely on
Object.definePropertyin some cases.This breaks spying on proxy's methods, because even if Jest is properly calling
Object.defineProperty, the cached value in thegetsection of the proxy is never updated, and the spy is in fact never used.This is easily reproducible as vue-next already uses a version of jest with these changes.
This is blocking projects (like vue-test-utils-next and vue-cli) to update to recent Jest versions.
This commit adds a
definePropertymethod to the proxy handler, that properly updates the defined value in the cache.Again, the fix is maybe too naive, and I'm happy to update the PR with a better solution.
edit: the same happens with Vitest