-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vue-apollo broken on 3.2.31 (was perfectly working on 3.2.30) #5415
Comments
Please follow Issue guidelines and provide a ( as runnable as possible) reproduction. We understand it may be hard, but we can't debug this by guessing what you might have one exactly. I mean, at the very, very, very least provide the actual error message that you get. |
Is there enough information to reopen this issue @LinusBorg ? 🙏 🥺 |
The error message was helpful. It's caused by an edge case of 8457d8b, where apollo defines a property with a getter on the component instance, and ghat getter would actually throw an error when called at that time as the object it accesses hasn'T been defined yet: Essentially, this here happens first: And only later, $apolloData is added, here: Which is an issue with the new change in 8457d8b because that fix immediately calls the getter:
Will need some thought tp be put in what the right fix is, though. |
Thanks a lot @LinusBorg for time and research. Also, congrats for the nice and quick catch you did! 👏 🎩 |
@cexbrayat: you're welcome, no problem, I simply fix @lidlanca: thanks for the so quick fix, can't wait for the upcoming vue release now 🥳 Vue.js is so cool, keep up the good work! 💪 😘 |
@LinusBorg @lidlanca - I came across this issue by way of vuejs/apollo#1350 . Looks like something in the fix in #5417 has still affected how the data is getting updated in vue apollo. I have an example app in a codesandbox in this issue: vuejs/apollo#1368 . It seems like reactivity is not totally working back to how it was in vue Is there something I can do to help track down the issue? |
Please open a new issue here with that reproduction (provided it's minimal, can't check it out tight now on mobile) and all additional information you can provide. |
@LinusBorg here you go #6099 |
Version
3.2.31
Reproduction link
I would be very happy to provide a reproduction link, but it's a bit hard to demonstrate without a graphql API. In addition, the vue sfc playground don't allow to install a dependency (or I don't find how to do it).
Steps to reproduce
Using option API, do a graphql query with vue-apollo.
What is expected?
retrieve data
What is actually happening?
console error, the network request is even not sent at all
The text was updated successfully, but these errors were encountered: