fix(runtime-core): allow calling hasOwnProperty on proxy #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently not possible to call `hasOwnProperty` on the proxy instance, which makes it impossible to spy with Jest, as Jest needs to call this method (see https://github.com/facebook/jest/blob/30e802036291f4c9c9fd4feef6faba485df54dd2/packages/jest-mock/src/index.ts#L986) This commit fixes this by properly returning the `hasOwnProperty` method in the `get` section of the proxy. There is currently a workaround in vue-test-utils-next that monkey patches the proxy to add the method (see https://github.com/vuejs/vue-test-utils-next/blob/23d3d3e1f4178a87de5023f5255e0623653affdc/src/mount.ts#L493-L495). This is temporarily fine, but developers trying to create spies without using @vue/test-utils will run into the same issue.
|
I feel this is something that should be fixed in Jest - its usage of Instead it should use |
|
Sounds good. I opened jestjs/jest#11721 in Jest itself |
|
The PR landed in Jest, and was released as v27.1 PR #4472 updates vue-next to use this new version which fixes the issue, making this PR obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to call
hasOwnPropertyon the proxy instance,which makes it impossible to spy with Jest, as Jest needs to call this method (see https://github.com/facebook/jest/blob/30e802036291f4c9c9fd4feef6faba485df54dd2/packages/jest-mock/src/index.ts#L986)
This commit fixes this by properly returning the
hasOwnPropertymethod in thegetsection of the proxy.There is currently a workaround in vue-test-utils-next that monkey patches the proxy to add the method (see https://github.com/vuejs/vue-test-utils-next/blob/23d3d3e1f4178a87de5023f5255e0623653affdc/src/mount.ts#L493-L495).
This is temporarily fine, but developers trying to create spies without using @vue/test-utils will run into the same issue.
The proposed fix is obviously very naive: the point was just to get the ball rolling 🙂