Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add trim and scoped postcss plugins at the start of plugin list #36

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

znck
Copy link
Member

@znck znck commented Oct 25, 2018

fixes #30

@znck znck merged commit 0d52d86 into vuejs:master Oct 28, 2018
@znck znck deleted the fix/style-processor branch October 28, 2018 20:52
@JounQin
Copy link
Contributor

JounQin commented Nov 6, 2018

@znck See #30 (comment)

plugins is always [] at beginning and your fix will not work.

@znck
Copy link
Member Author

znck commented Nov 7, 2018

Now trim and scoped plugins are added at the start of the plugins list, before any user defined plugins. Just to be sure, I'll add a test so it won't break.

@JounQin
Copy link
Contributor

JounQin commented Nov 7, 2018

There is no user defined plugins at all when using vue-loader because .scss files are handled by sass-loader and postcss-loader then it will be transformed into pure .css and no postcss plugins will be passed into compileStyle function.

You can check https://github.com/vuejs/vue-loader/blob/master/lib/loaders/pitcher.js#L92-L105 and https://github.com/vuejs/vue-loader/blob/master/lib/loaders/stylePostLoader.js

@znck
Copy link
Member Author

znck commented Nov 8, 2018

/cc @yyx990803

@trainiac
Copy link

@znck is there something holding up a release of this fix?

@znck
Copy link
Member Author

znck commented Nov 11, 2018

I am waiting for @yyx990803's take on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants