-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postcss does not work as expected with vue-loader #1395
Comments
I find out it is caused by https://github.com/vuejs/component-compiler-utils/blob/master/lib/stylePlugins/trim.ts#L7. It is named @yyx990803 @Jinjiang @blake-newman Please help... |
It seems @yyx990803 you have came back to 'work', would like to check about this issue? |
I'd love to see progress as well Related PR (merged but didn't solve the problem AFAIK): vuejs/component-compiler-utils#36 |
@JounQin Could you change the title of the PR to something more descriptive? 🤔 |
I just ran your reproduction and can't seem to reproduce the problem. I'm not sure how your repo even is related to Also not able to reproduce the minification issue via |
FYI, the trim plugin has always worked like that for over a year. This has never been a problem and unlikely to be the root cause. I just ran the repro from cssnano/cssnano#586 and it also minifies properly, so this is likely already fixed in some related dependency which originally caused the problem, unless a proper reproduction can be provided. |
I was able to reproduce this via Vue CLI as I noticed this only happens for CSS inlined in JavaScript. Let's track this in vuejs/component-compiler-utils#40 instead. |
Version
15.4.0
Reproduction link
JounQin/test@ba578d3
Steps to reproduce
Clone https://github.com/JounQin/test and checkout branch
vue-loader
, runyarn build
and checkdist/main.*.css
file, it is minified. Change code back to Vue style version and runyarn build
again,dist/main.*.css
is not minified correctly.What is expected?
dist/main.*.css
should be minified.What is actually happening?
dist/main.*.css
is not minified.The text was updated successfully, but these errors were encountered: