fix(ts): allow undefined for optional variables #962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #961, fixes #948, fixes #998, and closes #955. Also should fix the issue raised in dotansimha/graphql-code-generator#3679.
The problem was that I added typing in #895 with the expectation that if
TVariables
was specified, thenvariables
should be required. This is not the case, since queries, subscriptions, and mutations can have variables that are all optional. This is written up in #961.This has the positive benefit of simplifying the Frankenstein's Monster that the types in
useMutation
were becoming.