Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MutateWithOptionalVariables for mutations without default values #955

Closed
wants to merge 1 commit into from
Closed

Use MutateWithOptionalVariables for mutations without default values #955

wants to merge 1 commit into from

Conversation

tobias-kuendig
Copy link

This PR fixes #948

Since no defaults are specified with the useMutation call, variables might be undefined. This means MutateWithOptionalVariables should be used in the return statement.

@tobias-kuendig tobias-kuendig mentioned this pull request Apr 15, 2020
Open
@bbugh bbugh mentioned this pull request Apr 21, 2020
Open
@bbugh
Copy link
Contributor

bbugh commented Apr 21, 2020 •
edited
Loading

Hi! 👋 I'm the original author for the types of v4. This PR doesn't actually fix the underlying issue, but I made an issue that will address it. #961.

Submitted a PR for what I think is the actual issue: #962

@bbugh bbugh mentioned this pull request Apr 21, 2020
Merged
@Akryum Akryum closed this Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobias-kuendig @bbugh @Akryum