Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the options for the v2 of multiselect #240

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Update the options for the v2 of multiselect #240

merged 2 commits into from
Jun 27, 2017

Conversation

lionel-bijaoui
Copy link
Member

@lionel-bijaoui lionel-bijaoui commented Jun 26, 2017 •
edited
Loading

This is a WIP and I would like help to finish it.

see #239 for details and discussion

TODO:

  • find a solution for partials
  • update the test
  • update the documentation

@lionel-bijaoui lionel-bijaoui mentioned this pull request Jun 26, 2017
Closed
@lionel-bijaoui lionel-bijaoui requested review from dflock and icebob June 26, 2017 16:16
icebob
icebob approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@icebob icebob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! But Travis is broken

@icebob
Copy link
Member

icebob commented Jun 26, 2017

@lionel-bijaoui Is it blocking the stable v2 of vfg?

@lionel-bijaoui
Copy link
Member Author

@icebob Yeah, sorry, It's still in progress.
I don't know if it is blocking. Do you have a release date for the v2?

@icebob
Copy link
Member

icebob commented Jun 26, 2017

OK. I would like release stable in the week.

@lionel-bijaoui
Copy link
Member Author

Comment where not allowed in more than one place, hence the failure.
I just had to update one thing for the test to work.
@icebob if you validate, I will modify the doc.
The biggest change is that multiple is now under selectOptions.
I have checked the doc and except for multi there is no multiple option in the common properties of fields. This is why I moved it under selectOptions.

@icebob
Copy link
Member

icebob commented Jun 27, 2017

Thank you. Mergeable!

@lionel-bijaoui lionel-bijaoui merged commit b6e8cc5 into vue-generators:master Jun 27, 2017
@lionel-bijaoui lionel-bijaoui deleted the lb_multiselect_update branch June 27, 2017 08:39
@lionel-bijaoui lionel-bijaoui restored the lb_multiselect_update branch June 27, 2017 09:20
@lionel-bijaoui lionel-bijaoui deleted the lb_multiselect_update branch June 27, 2017 09:20
@lionel-bijaoui
Copy link
Member Author

lionel-bijaoui commented Jun 27, 2017 •
edited
Loading

Change made in the documentation.
I did another PR #242 for the missing option that I missed.
I took the liberty to merge it since it should have been part of this one and it is small.
Hope you don't mind.

@icebob
Copy link
Member

icebob commented Jun 27, 2017

Thanks. Doc is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

@dflock dflock Awaiting requested review from dflock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel-bijaoui @icebob