Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help to update VueMultiselect partial functionnality #239

Closed
lionel-bijaoui opened this issue Jun 26, 2017 · 6 comments
Closed

Help to update VueMultiselect partial functionnality #239

lionel-bijaoui opened this issue Jun 26, 2017 · 6 comments

Comments

@lionel-bijaoui
Copy link
Member

lionel-bijaoui commented Jun 26, 2017

The goal here is to update to the new API of VueMultiselect v2 (kinda relate to #193).
So far, I did the easiest part, cleaning old and unused props and adding the missing one. I also reordered the props to fit the documentation.

My biggest challenge so far is the new way to do custom rendering of the list.
Before, it was using Vue partials. But since Vue added scoped slot, they decided to use that instead.
The problem is that I don't see how we can implement an interface to send template elements into this slot.
I have little experience with scoped slot, but I'm not comfortable with them.
I always have a hard time wrapping my head around the concept, and this is another level of complexity.

So if anyone could help me find a nice solution, that would be very helpful.

PR here #240

@icebob
Copy link
Member

icebob commented Jun 26, 2017

Thanks the PR.
Currently I don't know also how we can add scoped slots to multiselect field.

Workaround: if somebodies want to use custom multiselect listing, they need to create custom fields with slots :)

@lionel-bijaoui
Copy link
Member Author

@icebob If we drop this functionality (at least for now), I can finish this faster. You validate ?

@icebob
Copy link
Member

icebob commented Jun 26, 2017

I think it is a bigger development (scoped slots thing), so I suggest to make it later, after the stable v2.

@icebob icebob added later and removed in progress labels Jun 30, 2017
@icebob
Copy link
Member

icebob commented Jun 30, 2017

@lionel-bijaoui full dev example is not working after #240.
image

@lionel-bijaoui lionel-bijaoui mentioned this issue Jun 30, 2017
@lionel-bijaoui
Copy link
Member Author

#245 will fix it

@icebob
Copy link
Member

icebob commented Jun 30, 2017

Thx. It works.

@icebob icebob closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants