Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add independent vanilla field components #31

Closed
4 tasks done
icebob opened this issue Aug 10, 2016 · 14 comments
Closed
4 tasks done

Add independent vanilla field components #31

icebob opened this issue Aug 10, 2016 · 14 comments

Comments

@icebob
Copy link
Member

icebob commented Aug 10, 2016

Create fields with vanilla libs which have no jQuery and Bootstrap dependencies.

For these developments I created an independent branch. Every PR needs to add to this branch.

https://github.com/icebob/vue-form-generator/tree/independent

@icebob icebob changed the title Add dependent vanilla field components Add independent vanilla field components Aug 10, 2016
@lionel-bijaoui
Copy link
Member

noUiSlider is almost ready.
By default, noUiSlider return a float so I need a way to check if validators.integer is activated so I can parseInt the value if necessary.

@lionel-bijaoui
Copy link
Member

I will go with cleave.js, the API is much easier to work with and it is way more popular.

@icebob
Copy link
Member Author

icebob commented Aug 12, 2016

Great!

@icebob
Copy link
Member Author

icebob commented Aug 12, 2016

@lionel-bijaoui in the next 7 days I will on holiday, so my response will be longer, but I will check your commits as soon as possible 👍

@lionel-bijaoui
Copy link
Member

That's perfect, I'm going on holiday too :)
I hope to do a PR for cleave and pikaday before the end of the day (just to initiate your feedback on them, I need some help).
Have a nice holiday !

@icebob
Copy link
Member Author

icebob commented Aug 12, 2016

@lionel-bijaoui Thanks! You have a nice holiday too!

@icebob
Copy link
Member Author

icebob commented Aug 21, 2016

@lionel-bijaoui I merged your fields. Fix lint errors and fix issues what I commented in your PR. So please rebase your fork.

@lionel-bijaoui
Copy link
Member

lionel-bijaoui commented Aug 22, 2016 via email

@lionel-bijaoui
Copy link
Member

@icebob should I destroy my branches ?

@icebob
Copy link
Member Author

icebob commented Aug 22, 2016

Yes, if you want.

@icebob
Copy link
Member Author

icebob commented Aug 22, 2016

I will merge this independent branch to master

@lionel-bijaoui
Copy link
Member

So soon ? Don't we need the unit test and all ?

@icebob
Copy link
Member Author

icebob commented Aug 22, 2016

This merge doesn't mean it will be a release :)
And need some tests for other fields too #40

icebob added a commit that referenced this issue Aug 22, 2016
⭐ Merge independent component #31
@icebob
Copy link
Member Author

icebob commented Aug 22, 2016

Merged with #42

@icebob icebob closed this as completed Aug 22, 2016
@icebob icebob mentioned this issue Aug 22, 2016
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants