Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less dependency ? More modularity ? #18

Closed
lionel-bijaoui opened this issue Jul 27, 2016 · 7 comments
Closed

Less dependency ? More modularity ? #18

lionel-bijaoui opened this issue Jul 27, 2016 · 7 comments

Comments

@lionel-bijaoui
Copy link
Member

Hello,

I was wandering if it could be possible to use less dependency or smaller, more focused one. For example, what is the use of jQuery ? Why Bootstrap ?
It is something that is actually stopping me from using this component, because I don't want to bloat my web app with jQuery and Bootstrap. It's a shame really because I really need the functionality provided by your component.

Also, I could be awesome if we could choose the kind of input in a more modular way.
For example, if I don't use range slider fields, I could avoid ion.rangeSlider. If I want to use noUiSlider instead, I could create a new submodule easily. It seem to be already possible, but I wanted to be sure.

I'm ready to help, if you think this is technically possible.
Thank you for your hard work.

@icebob
Copy link
Member

icebob commented Jul 27, 2016

Hello,

jQuery and Bootstrap is not required dependent, just optional. If you want to use bootstrap-based optional components, you need load these libraries too.
If you see jquery is not used in the components. Just in the examples. But I plan to change the bootstrap-* components to other vanillaJS components. E.g bootstrap-select to vue-multiselect

Shortly, if you don't load jQuery & Bootstrap, you can use the 13 built-in fields properly.
Like this: https://jsfiddle.net/0mg1v81e/13/
If I remove bootstrap it will be ugly, need some CSS, but working :)

Btw I'm accept any help, because I'm working other projects too.

@lionel-bijaoui
Copy link
Member Author

Okay, sorry, it wasn't very clear that you could do without them from the Doc/Readme.
That perfect ! I'm going to test the component in my project and start styling.

vue-multiselect would be fantastic. I'm going to look at the source code and see if I can help with that. I'm not a super ninja dev so don't expect great/fast/any result from this. 😶

Thanks a lot for your fast answer !

@icebob
Copy link
Member

icebob commented Jul 27, 2016

👍 Happy testing :)

@lionel-bijaoui
Copy link
Member Author

lionel-bijaoui commented Aug 10, 2016

I understand you are working toward the 0.4.0, but I would like to continue toward less dependency.
My main goal is to get rid of jQuery. So I need to implement bootstrap based field using other lib. I'm choosing the most popular equivalent (most stars on github).
Remaining fields:

What do you think about that ?

@icebob
Copy link
Member

icebob commented Aug 10, 2016

@lionel-bijaoui it's great idea. I want to independent from bootstrap too. I create a new issue about it and create a new branch because it is a bigger development. Right?

@lionel-bijaoui
Copy link
Member Author

Ok 😎

@icebob
Copy link
Member

icebob commented Aug 10, 2016

#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants