feat: implement redirect query #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git-the-Sanz
requested review from
gvc and
icazevedo
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 881ee90:
|
gvc
reviewed
May 5, 2023
icazevedo
reviewed
May 8, 2023
icazevedo
reviewed
May 8, 2023
There was a problem hiding this comment.
Also, I'm only now realizing the return type of the query is String. This doesn't scale well, as it prevents any other additions in the future. I think we should change it to an object that can be of type Thing. It has an url field and, in the future, I see us using the identifier field to specify the status code of the redirect. I can also evolve into any other parent type, as it would be a very generic one for now.
icazevedo
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR adds a query to solve redirects when performing a search.
In case of VTEX platform, this is solved by the IS api.
How it works?
When performing a search if a term or facet has a redirect, the value of the
redirectfield should be an URL; this can later be used to redirect the user to an internal or external URL.From VTEX admin:
It get solved as:
How to test it?
@faststore/apipackage individually./admin/search/v4/redirects/techPR related at vtex-sites: vtex-sites/nextjs.store#382
PR related 2.x: #1749