-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Search Redirect #382
Open
beatrizmaselli
wants to merge
3
commits into
main
Choose a base branch
from
add/search-redirect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* add shouldSplitItem * adjust default behaviour
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 9bed9aa
|
beatrizmaselli
added a commit
to vtex/faststore
that referenced
this pull request
May 9, 2023
## What's the purpose of this pull request? This PR adds a query to solve redirects when performing a search. In case of VTEX platform, this is solved by the IS api. ## How it works? When performing a search if a term or facet has a redirect, the value of the `redirect` field should be an URL; this can later be used to redirect the user to an internal or external URL. From VTEX admin: <img width="795" alt="Screenshot 2023-05-04 at 17 51 48" src="https://user-images.githubusercontent.com/50715158/236261672-24230b76-3f5e-4f92-8c17-53111fd65f24.png"> It get solved as: <img width="1474" alt="image" src="https://github.com/vtex/faststore/assets/67066494/4cecfa15-200b-49a0-a070-e4226f57c71e"> ## How to test it? - Run the `@faststore/api` package individually. - Browse [localhost/graphql](http://localhost:4000/graphql) - Run the redirect query with a term that is active in `/admin/search/v4/redirects/` - For storeframework, you can use the term `tech` PR related at vtex-sites: vtex-sites/nextjs.store#382 PR related 2.x: #1749 --------- Co-authored-by: beatrizmaselli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Add redirect feature in search context
How does it work?
Add the local API package of the PR
How to test it?
We have two types of redirect available (term / facet) or a mix of both:
term
facet
term + facet
screen-recording-2023-05-08-at-174924_9dTHBUFF.mp4