Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve integration tests by upgrading Cypress to 9.5.4 #177

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

filipewl
Copy link
Contributor

@filipewl filipewl commented Jul 19, 2022

What's the purpose of this pull request?

From 6.6.0. This way, it matches Cypress version run by WebOps that was recently updated.

How to test it?

Run yarn develop and then yarn test.

From 6.6.0. This way it matches [Cypress version run by WebOps that was recently updated][1].

[1]: https://github.com/vtex/vtex-cicd-platform/pull/182
@filipewl filipewl marked this pull request as draft July 19, 2022 13:26
@vercel vercel bot temporarily deployed to Preview July 19, 2022 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview July 19, 2022 14:10 Inactive
@filipewl filipewl marked this pull request as ready for review July 19, 2022 14:24
@filipewl filipewl self-assigned this Jul 19, 2022
@filipewl filipewl added the Chore General tasks. label Jul 19, 2022
@filipewl filipewl requested a review from a team July 19, 2022 14:24
Copy link
Member

@eduardoformiga eduardoformiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@@ -19,11 +19,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Applies new local tokens to `CartSidebar` ([#145](https://github.com/vtex-sites/nextjs.store/pull/145))
- Global tokens doc page on storybook ([#147](https://github.com/vtex-sites/nextjs.store/pull/147))
- Adds [bun](https://bun.sh/) compatiblity ([#164](https://github.com/vtex-sites/nextjs.store/pull/164))
- Uses new cross selling API on PDP ([#137](https://github.com/vtex-sites/gatsby.store/pull/137))
- Uses new cross selling API on PDP ([#159](https://github.com/vtex-sites/nextjs.store/pull/159))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@vtex-sites
Copy link

vtex-sites bot commented Jul 19, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-facdb3b--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit facdb3b

@vtex-sites
Copy link

vtex-sites bot commented Jul 19, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit facdb3b

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@filipewl filipewl deleted the chore/cypress-9.5.4 branch July 19, 2022 19:28
filipewl added a commit that referenced this pull request Jul 22, 2022
## What's the purpose of this pull request?

From 9.5.4. This way, it matches [Cypress version run by WebOps that was recently updated][1].

[1]: https://github.com/vtex/vtex-cicd-platform/pull/217

## How to test it?

Run `yarn develop` and then `yarn test`.

## References

Similar to #177.
@eduardoformiga eduardoformiga changed the title chore: Improve integration tests by upgrading Cypress to 9.6.5 chore: Improve integration tests by upgrading Cypress to 9.5.4 Jul 22, 2022
gvc pushed a commit to vtex/faststore that referenced this pull request Feb 7, 2023
## What's the purpose of this pull request?

From 9.5.4. This way, it matches [Cypress version run by WebOps that was recently updated][1].

[1]: vtex/vtex-cicd-platform#217

## How to test it?

Run `yarn develop` and then `yarn test`.

## References

Similar to vtex-sites/nextjs.store#177.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore General tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants