Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve integration tests by upgrading Cypress to 9.5.4 #148

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

filipewl
Copy link
Contributor

What's the purpose of this pull request?

From 6.6.0. This way, it matches Cypress version run by WebOps that was recently updated.

How to test it?

Run yarn develop and then yarn test.

From 6.6.0. This way it matches [Cypress version run by WebOps that was recently updated][1].

[1]: https://github.com/vtex/vtex-cicd-platform/pull/182
@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gatsby-store-storybook ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 2:08PM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented Jul 19, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-e583194--gatsby.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit e583194

@vtex-sites
Copy link

vtex-sites bot commented Jul 19, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit e583194

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@filipewl filipewl marked this pull request as ready for review July 19, 2022 14:24
@filipewl filipewl self-assigned this Jul 19, 2022
@filipewl filipewl added the Chore General tasks. label Jul 19, 2022
@filipewl filipewl requested a review from a team July 19, 2022 14:24
@filipewl
Copy link
Contributor Author

filipewl commented Jul 19, 2022

Considering these are simple changes and that they have been approved via vtex-sites/nextjs.store#177, I'm going to go ahead and merge this. Do let me know if you find any issues!

@filipewl filipewl merged commit e583194 into main Jul 19, 2022
@filipewl filipewl deleted the chore/cypress-9.5.4 branch July 19, 2022 15:00
@eduardoformiga eduardoformiga changed the title chore: Improve integration tests by upgrading Cypress to 9.6.5 chore: Improve integration tests by upgrading Cypress to 9.5.4 Jul 22, 2022
filipewl pushed a commit that referenced this pull request Jul 22, 2022
## What's the purpose of this pull request?

From 9.5.4. This way, it matches [Cypress version run by WebOps that was recently updated][1].

[1]: https://github.com/vtex/vtex-cicd-platform/pull/217

## How to test it?

Run `yarn develop` and then `yarn test`.

## References

Similar to #148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore General tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant