Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adds tokens to Filter #139

Merged
merged 37 commits into from
Jun 29, 2022
Merged

Feat: Adds tokens to Filter #139

merged 37 commits into from
Jun 29, 2022

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jun 20, 2022 •
edited by renatamottam
Loading

What's the purpose of this pull request?

This PR applies the new Theming structure to Filter: new scoped tokens linked to global ones. It also split the FilterSlider into its own file

Additionally, we created a new Storybook component for lists: <SectionList>. You can use it as Row or Grid and it should still be placed on the following docs (on a future PR):

  • Buttons
  • Modal
  • Regionalization
  • Accordion

How does it work?

This PR uses local variables to parameterize the Filter properties, then connects these scoped tokens to the global ones.

Screen Shot 2022-06-21 at 21 31 43

How to test it?

  • The Filter component and its related components should look just as it was before these changes.
  • You can check the story on Storybook.

The overview session adapts according to the screen dimensions:

295VdnOKYu

Checklist

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.

@vercel
Copy link

vercel bot commented Jun 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 5:08PM (UTC)

@vercel vercel bot temporarily deployed to preview June 20, 2022 22:59 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 20, 2022 •
edited
Loading

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-c1e5abc--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit c1e5abc

@vtex-sites
Copy link

vtex-sites bot commented Jun 20, 2022 •
edited
Loading

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit c1e5abc

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@vercel vercel bot temporarily deployed to preview June 21, 2022 22:21 Inactive
@vercel vercel bot temporarily deployed to preview June 21, 2022 22:54 Inactive
@vercel vercel bot temporarily deployed to preview June 21, 2022 23:21 Inactive
@eduardoformiga eduardoformiga added Documentation Improvements or additions to documentation Features New feature or request Chore General tasks. labels Jun 22, 2022
@vercel vercel bot temporarily deployed to preview June 22, 2022 00:27 Inactive
@renatamottam renatamottam requested a review from hellofanny June 28, 2022 20:43
@vercel vercel bot temporarily deployed to preview June 28, 2022 20:50 Inactive
@vercel vercel bot temporarily deployed to preview June 28, 2022 21:01 Inactive
@vercel vercel bot temporarily deployed to preview June 28, 2022 21:54 Inactive
@renatamottam renatamottam mentioned this pull request Jun 29, 2022
Merged
8 tasks
@vercel vercel bot temporarily deployed to preview June 29, 2022 14:19 Inactive
lucasfp13
lucasfp13 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@lucasfp13 lucasfp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

src/components/search/Filter/Facets.stories.mdx Show resolved Hide resolved
src/components/search/Filter/FilterSlider.stories.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to preview June 29, 2022 16:59 Inactive
@vercel vercel bot temporarily deployed to preview June 29, 2022 17:02 Inactive
@vercel vercel bot temporarily deployed to preview June 29, 2022 17:08 Inactive
hellofanny
hellofanny approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeee! LGTM! 🌟

@eduardoformiga eduardoformiga merged commit c1e5abc into main Jun 29, 2022
@eduardoformiga eduardoformiga deleted the feat/theming-filter-fsss-380 branch June 29, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfp13 lucasfp13 lucasfp13 approved these changes

@hellofanny hellofanny hellofanny approved these changes

@ArthurTriis1 ArthurTriis1 Awaiting requested review from ArthurTriis1

Assignees

@eduardoformiga eduardoformiga

@renatamottam renatamottam

Labels
Documentation Improvements or additions to documentation Features New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eduardoformiga @hellofanny @lucasfp13 @renatamottam