-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adds tokens to Navbar
#142
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-5c27797--nextjs.preview.vtex.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments below as an effort to simplify these tokens :)
Co-authored-by: Renata Motta <[email protected]>
Thank you, @renatamottam. 💛 |
…x-sites/nextjs.store into feat/theming-navbar-fsss-377
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Approved with tiny suggestions :)
43b689f
to
20ea86a
Compare
Co-authored-by: Renata Motta <[email protected]>
What's the purpose of this pull request?
This PR applies the new Theming structure to
Navbar
: new scoped tokens linked to global ones.It also refactors and split the navbar-related components as
NavbarSlider
to its own file.How does it work?
This PR uses local variables to parameterize the
Navbar
properties, then connects these scoped tokens to the global ones.Tokens can be visualized in the storybook.
How to test it?
Navbar
component and its related components should look just as it was before these changes.Checklist
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation