Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adds tokens to Navbar #142

Merged
merged 45 commits into from
Jul 1, 2022
Merged

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jun 22, 2022

What's the purpose of this pull request?

This PR applies the new Theming structure to Navbar: new scoped tokens linked to global ones.

It also refactors and split the navbar-related components as NavbarSlider to its own file.

How does it work?

This PR uses local variables to parameterize the Navbar properties, then connects these scoped tokens to the global ones.

Tokens can be visualized in the storybook.

How to test it?

  • The Navbar component and its related components should look just as it was before these changes.
  • You can check the story on Storybook.

Checklist

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:54PM (UTC)

@vercel vercel bot temporarily deployed to preview June 22, 2022 23:40 Inactive
@vercel vercel bot temporarily deployed to preview June 22, 2022 23:41 Inactive
@vercel vercel bot temporarily deployed to preview June 22, 2022 23:44 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 22, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-5c27797--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 5c27797

@eduardoformiga eduardoformiga self-assigned this Jun 23, 2022
@vercel vercel bot temporarily deployed to preview June 23, 2022 17:14 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 19:11 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 19:20 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 19:22 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 19:24 Inactive
@eduardoformiga eduardoformiga marked this pull request as ready for review June 23, 2022 19:27
@eduardoformiga eduardoformiga requested a review from a team June 23, 2022 19:27
@eduardoformiga eduardoformiga added Documentation Improvements or additions to documentation Features New feature or request labels Jun 23, 2022
@eduardoformiga eduardoformiga requested review from a team and removed request for a team June 23, 2022 20:04
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments below as an effort to simplify these tokens :)

src/components/common/Navbar/navbar.module.scss Outdated Show resolved Hide resolved
src/components/common/Navbar/navbar.module.scss Outdated Show resolved Hide resolved
src/components/common/Navbar/navbar.module.scss Outdated Show resolved Hide resolved
src/components/common/Navbar/navbar.module.scss Outdated Show resolved Hide resolved
src/components/common/Navbar/NavbarSlider.stories.mdx Outdated Show resolved Hide resolved
src/components/common/Navbar/navlinks.module.scss Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 30, 2022 15:20 Inactive
@vercel vercel bot temporarily deployed to Preview June 30, 2022 15:24 Inactive
@vercel vercel bot temporarily deployed to Preview June 30, 2022 15:27 Inactive
@eduardoformiga
Copy link
Member Author

Left some comments below as an effort to simplify these tokens :)

Thank you, @renatamottam. 💛
I agree with all suggestions.

@vercel vercel bot temporarily deployed to Preview June 30, 2022 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview June 30, 2022 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview June 30, 2022 20:23 Inactive
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Approved with tiny suggestions :)

src/components/common/Navbar/navlinks.module.scss Outdated Show resolved Hide resolved
src/components/common/Navbar/NavLinks.stories.mdx Outdated Show resolved Hide resolved
src/components/common/Navbar/NavLinks.stories.mdx Outdated Show resolved Hide resolved
@hellofanny hellofanny mentioned this pull request Jun 30, 2022
7 tasks
@eduardoformiga eduardoformiga force-pushed the feat/theming-navbar-fsss-377 branch from 43b689f to 20ea86a Compare July 1, 2022 13:49
@vercel vercel bot temporarily deployed to Preview July 1, 2022 13:51 Inactive
@vercel vercel bot temporarily deployed to Preview July 1, 2022 13:54 Inactive
@eduardoformiga eduardoformiga merged commit 5c27797 into main Jul 1, 2022
@eduardoformiga eduardoformiga deleted the feat/theming-navbar-fsss-377 branch July 1, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants