Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Regionalization Doc Storybook #110

Merged
merged 32 commits into from
Jun 27, 2022
Merged

Feat: Regionalization Doc Storybook #110

merged 32 commits into from
Jun 27, 2022

Conversation

renatamottam
Copy link
Collaborator

@renatamottam renatamottam commented Jun 9, 2022 •
edited
Loading

What's the purpose of this pull request?

Creates a page for Regionalization feature to list all its components and how to use it.
Also, this PR brings changes from #104.

How does it work?

Each feature will now have its own page and should:

  1. Explain its usage and purpose
  2. List components with descriptions
  3. Add possibility to test it
Preview

How to test it?

See preview link

Checklist

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@renatamottam renatamottam self-assigned this Jun 9, 2022
@vercel
Copy link

vercel bot commented Jun 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 27, 2022 at 3:42PM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented Jun 9, 2022 •
edited
Loading

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-2d958da--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 2d958da

@vercel vercel bot temporarily deployed to preview June 9, 2022 14:15 Inactive
@vercel vercel bot temporarily deployed to preview June 9, 2022 14:28 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 9, 2022 •
edited
Loading

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 2d958da

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@vercel vercel bot temporarily deployed to preview June 9, 2022 16:43 Inactive
Renata Motta and others added 2 commits June 9, 2022 15:02
@hellofanny
Improves Regionalization import text
8a7342a 
Co-authored-by: Fanny Chien <[email protected]>
@hellofanny
Fixes typo
b705df5 
Co-authored-by: Fanny Chien <[email protected]>
@vercel vercel bot temporarily deployed to preview June 9, 2022 19:08 Inactive
@renatamottam renatamottam added Documentation Improvements or additions to documentation Features New feature or request labels Jun 13, 2022
Renata Motta and others added 2 commits June 15, 2022 09:34
@hellofanny
Improves copy
653cb0d 
Co-authored-by: Fanny Chien <[email protected]>
@hellofanny
Fixes regionalization tokens
ac01137 
Co-authored-by: Fanny Chien <[email protected]>
@vercel vercel bot temporarily deployed to preview June 15, 2022 12:36 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2022 13:07 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2022 13:21 Inactive
hellofanny
hellofanny approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved ✅ (just waiting the link to the RegionalizationModal when available).
This doc looks great!! Well done! 🤩
Small suggestion: rename Default to Overview. I think it fits better; what do you think?

image

@vercel vercel bot temporarily deployed to preview June 23, 2022 19:45 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 20:05 Inactive
@hellofanny
Copy link
Contributor

Looks beautifuuuul! 🤩

@vercel vercel bot temporarily deployed to preview June 27, 2022 13:13 Inactive
ArthurTriis1
ArthurTriis1 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@ArthurTriis1 ArthurTriis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@vercel vercel bot temporarily deployed to preview June 27, 2022 15:42 Inactive
@renatamottam renatamottam merged commit 2d958da into main Jun 27, 2022
@renatamottam renatamottam deleted the feat/theming-regionalization-doc-fsss-387 branch June 27, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellofanny hellofanny hellofanny approved these changes

@ArthurTriis1 ArthurTriis1 ArthurTriis1 approved these changes

@carolinamenezes carolinamenezes Awaiting requested review from carolinamenezes

Assignees

@renatamottam renatamottam

@ArthurTriis1 ArthurTriis1

Labels
Documentation Improvements or additions to documentation Features New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renatamottam @hellofanny @ArthurTriis1