Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tokens to RegionalizationBar #104

Closed
wants to merge 3 commits into from

Conversation

ArthurTriis1
Copy link
Contributor

What's the purpose of this pull request?

This PR applies the new Theming structure to RegionalizationBar: new scoped tokens linked to global ones.

Additionally, I adjusted the RegionalizationBar's style.

How does it work?

This PR uses local variables to parameterize the RegionalizationBar properties, then connects these scoped tokens to the global ones.

Screen Shot 2022-06-07 at 10 19 11

Tokens

Screen Shot 2022-06-07 at 10 24 02

Local tokenDefault value/Global token linked
--fs-regionalization-bar-width100%

Button

Local tokenDefault value/Global token linked
--fs-regionalization-bar-button-width100%
--fs-regionalization-bar-button-paddingvar(--fs-spacing-0) var(--fs-spacing-3)
--fs-regionalization-bar-button-color
var(--fs-color-text-display)
--fs-regionalization-bar-button-background-color
var(--fs-color-neutral-0)
--fs-regionalization-bar-button-border0

Input Message

Local tokenDefault value/Global token linked
--fs-regionalization-bar-input-message-margin-rightauto
--fs-regionalization-bar-input-message-font-weightvar(--fs-text-weight-regular)

Variants

Postal Code setted in SessionProvider

Screen Shot 2022-06-07 at 10 22 34

Edit Message

Local tokenDefault value/Global token linked
--fs-regionalization-bar-edit-message-margin-leftauto
--fs-regionalization-bar-edit-message-text-decorationunderline

Postal Code

Local tokenDefault value/Global token linked
--fs-regionalization-bar-postal-code-margin-rightauto
--fs-regionalization-bar-postal-code-font-weightvar(--fs-text-weight-regular)

How to test it?

Checklist

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)
  • Updated the Storybook - if applicable.
  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.

@ArthurTriis1 ArthurTriis1 added Documentation Improvements or additions to documentation Features New feature or request labels Jun 7, 2022
@ArthurTriis1 ArthurTriis1 self-assigned this Jun 7, 2022
@vercel
Copy link

vercel bot commented Jun 7, 2022

Deployment failed with the following error:

Resource is limited - try again in 7 minutes (more than 100, code: "api-deployments-free-per-day").

@ArthurTriis1 ArthurTriis1 marked this pull request as draft June 7, 2022 13:25
@vtex-sites
Copy link

vtex-sites bot commented Jun 7, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-d37e0b1--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit d37e0b1

Signed-off-by: Arthur Andrade <[email protected]>
@vercel
Copy link

vercel bot commented Jun 7, 2022

Deployment failed with the following error:

Resource is limited - try again in 5 minutes (more than 100, code: "api-deployments-free-per-day").

@ArthurTriis1 ArthurTriis1 marked this pull request as ready for review June 7, 2022 13:27
@ArthurTriis1 ArthurTriis1 changed the title feat: add tokens to RegionalizationBar feat: add tokens to RegionalizationBar Jun 7, 2022
@vtex-sites
Copy link

vtex-sites bot commented Jun 7, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit d37e0b1

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse-99988212/p
📎   /office

@emersonlaurentino emersonlaurentino deleted the feat/add-tokens-to-RegionalizationBar branch September 19, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant