Feat: adds tokens to PriceRange
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates `PriceRange` tokens * Begins to add `InputText` for `PriceRange` * Minor code improvements * Fixes `PriceRange` input hover * Makes slider inputs change along with the other inputs * Adds price formatter options to support format price without decimals * Fixes `onChange` callbacks for min/max inputs * Updates FS package * Tweaks `PriceRange` label * Updates Changelog * Updates FS package * Bump `@faststore/ui` version * Improves PriceRange * Uses `onEnd` instead `onChange` for `UIPriceRange` * Handles external `onEnd` definitions * Round absolute values * Bump `@faststore/ui` version * Fixes `PriceRange` slider selection token * Removes unneeded `argTypes` from `ArgsTable` * Some improvements in min/max price validations; Submit action through inputs' `onBlur` callbacks * Updates `PriceRange` tokens * Tweaks `Input` message * Fixes `PriceRange` step * Removes unneeded `argTypes` from `ArgsTable` * Use Math's `ceil` instead `round` for max absolute price * Sets standard `step` (1) to FS's `PriceRange` * Adds hover state for `Slider` thumbs * Tweaks `PriceRange` tokens * Bump `@faststore/ui` version * Improves `InputText` message * Attempts to fix Value Label interaction * Fixes Value Label position * Formats absolute prices to match with the `Slider` thumb values * Update Changelog Co-authored-by: Filipe W. Lima <[email protected]> * Fixes `PriceRange` token list Co-authored-by: Filipe W. Lima <[email protected]> * Updates `PriceRange` token list Co-authored-by: Lucas Feijó <[email protected]> Co-authored-by: Filipe W. Lima <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
renatamottam
added
Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR applies the new Theming structure to
PriceRange: new scoped tokens linked to global ones.How does it work?
This PR uses local variables to parameterize the
PriceRangeproperties, then connects these scoped tokens to the global ones.Tokens list can be visualized in the Storybook.
How to test it?
PriceRangecomponent and its related components should look just as it was before these changes.Checklist
PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.Documentation