Feat: Adds new tokens to Breadcrumb
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds CSS Modules and themification to breadcrumb * Tweaks hover first item * Creates Breadcrumb stories using new format * Adds CHANGELOG entry * Adds margin top token * Removes irrelevant rule * tweaks bkg token name Co-authored-by: Renata Motta <[email protected]> * Removes margin token from button * Uses DotsThree icon instead of text * Centralizes dropdown button * Tweaks tokens to use home instead of first * Uses last-child instead of current data-attr * Trigger CI Co-authored-by: Renata Motta <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-1219255--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 1219255
|
renatamottam
approved these changes
Jul 12, 2022
renatamottam
added
Documentation
renatamottam
pushed a commit
that referenced
this pull request
Aug 3, 2022
* Updates `PriceRange` tokens * Begins to add `InputText` for `PriceRange` * Minor code improvements * Fixes `PriceRange` input hover * Makes slider inputs change along with the other inputs * Adds price formatter options to support format price without decimals * Fixes `onChange` callbacks for min/max inputs * Updates FS package * Tweaks `PriceRange` label * Updates Changelog * Updates FS package * Bump `@faststore/ui` version * Improves PriceRange * Uses `onEnd` instead `onChange` for `UIPriceRange` * Handles external `onEnd` definitions * Round absolute values * Bump `@faststore/ui` version * Fixes `PriceRange` slider selection token * Removes unneeded `argTypes` from `ArgsTable` * Some improvements in min/max price validations; Submit action through inputs' `onBlur` callbacks * Updates `PriceRange` tokens * Tweaks `Input` message * Fixes `PriceRange` step * Removes unneeded `argTypes` from `ArgsTable` * Use Math's `ceil` instead `round` for max absolute price * Sets standard `step` (1) to FS's `PriceRange` * Adds hover state for `Slider` thumbs * Tweaks `PriceRange` tokens * Bump `@faststore/ui` version * Improves `InputText` message * Attempts to fix Value Label interaction * Fixes Value Label position * Formats absolute prices to match with the `Slider` thumb values * Update Changelog Co-authored-by: Filipe W. Lima <[email protected]> * Fixes `PriceRange` token list Co-authored-by: Filipe W. Lima <[email protected]> * Updates `PriceRange` token list Co-authored-by: Lucas Feijó <[email protected]> Co-authored-by: Filipe W. Lima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Ported from vtex-sites/nextjs.store#162
This PR applies the new Theming structure to
Breadcrumb: new scoped tokens linked to global ones.How does it work?
This PR uses local variables to parameterize the
Breadcrumband then connects these scoped tokens to the global ones.Tokens can be visualized in the storybook.
How to test it?
Breadcrumbcomponent and its related components should look just as it was before these changes.References
https://www.figma.com/file/zHMOtOPduiM0hNNcg21iR1/Handoff-v1(PDP)?node-id=18%3A33143
Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation